Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
| [tool.setuptools.packages.find] | ||
| include = ["iris*"] | ||
| where = ["."] | ||
| include = ["iris", "iris.*", "iris.demo"] |
There was a problem hiding this comment.
The pattern "iris.*" already matches all subpackages under iris, making the explicit "iris.demo" entry redundant. Consider removing "iris.demo" from the include list since it's already covered by the wildcard pattern.
| include = ["iris", "iris.*", "iris.demo"] | |
| include = ["iris", "iris.*"] |
| def get_demo_file(example=None): | ||
| demo_file = join( | ||
| os.getcwd(), "demo", "cloud-segmentation.json" | ||
| ) | ||
| demo_file_repo = Path(__file__).parent.parent / "demo" / "cloud-segmentation.json" | ||
| demo_file_installed = Path(__file__).parent / "demo" / "cloud-segmentation.json" | ||
|
|
||
| demo_file = demo_file_repo if demo_file_repo.exists() else demo_file_installed | ||
| return str(demo_file) |
There was a problem hiding this comment.
The updated get_demo_file function should have test coverage to ensure it correctly handles both development (repository) and installed package scenarios. Consider adding tests that verify the function returns the correct path in both cases.
| - name: Install pypa/build & build a binary wheel and a source tarball | ||
| if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.12' | ||
| run: | | ||
| uv pip install build --user |
There was a problem hiding this comment.
Using 'uv pip install build --user' may not work as expected. The '--user' flag is for standard pip and may not be compatible with uv's pip interface. Consider using 'uv pip install build' without the '--user' flag, as uv manages its own virtual environments.
| uv pip install build --user | |
| uv pip install build |
Description
Brief description of what this PR does.
Changes
Demo
# Example commands to test the changes uv run iris --helpRelated Issue
Closes #[issue_number]
Additional Notes
Any additional context or notes for reviewers.